Macos ci #1339
Draft
Macos ci #1339
+58
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI run failed because for some reason it didn't manage to delete the temp directory it creates in |
|
Thanks for working on this! I think I've seen the temp dir removal issue myself as well. Would be great if we could figure out a workaround. If we can't, we should allow it to fail only on macOS. |
yedayak
force-pushed
the
macos-ci
branch
3 times, most recently
from
e94114a to
34a0d71
Compare
yedayak
force-pushed
the
macos-ci
branch
11 times, most recently
from
ad44019 to
2e6e2c9
Compare
yedayak
force-pushed
the
macos-ci
branch
4 times, most recently
from
17a1477 to
eaa8ce1
Compare
Closed
4 tasks
yedayak
force-pushed
the
macos-ci
branch
2 times, most recently
from
f6c04d4 to
4331cfa
Compare
This was referenced Sep 28, 2025
yedayak
force-pushed
the
macos-ci
branch
14 times, most recently
from
511147b to
cf77da1
Compare
Also use venv instead of global install brew/python doesn't like installing python packages globally: ``` error: externally-managed-environment × This environment is externally managed ```
vipw seems to have -d as an option on macos now. Partially reverts ccf7bf6 "test(dmesg,vipw): expect no options on macOS"
It seems there is some behaviour differences regarding the order completions are returned in between linux and macos, specifically regarding sorting of upper case and lowercase letters. Sorting them ourselves in the tests makes it consistent.
There is a BSD licensed version of rsync at https://github.com/kristapsdz/openrsync, and its what comes with macOS
On macOS we need sudo to delete them, maybe because they were created by a different prcoess?
yedayak
commented
Oct 9, 2025
| return str(tmpdir) | ||
| yield str(tmpdir) | ||
| if sys.platform == "darwin": | ||
| assert_bash_exec(bash, "sudo rm -rf %s/*" % tmpdir) |
There was a problem hiding this comment.
I don't love running sudo in the test suite, but I couldn't find a another way to delete these files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #726
Cherry-picked from here: